[PATCH] Emit .debug_str and DW_FORM_strp where appropriate

Richard Henderson rth@redhat.com
Wed Nov 7 11:54:00 GMT 2001


On Wed, Nov 07, 2001 at 02:28:05AM -0500, Jakub Jelinek wrote:
> Sorry, the separated indirect constant patch is attached below.

Ok to commit this.

> > (1) I don't think the .debug_str code should go in dwarf2asm.c.
> 
> You mean the named_section_flags call, or the whole
> dw2_output_indirect_string etc.?

The whole dw2_output_indirect_string.  Everything else is
also used by except.c.

> The point was that dw2_output_indirect_string would be able to get reference
> to .debug_str strings always, but dwarf2out.c would only use it if it can
> expect the linker to do some duplication merging magic, because otherwise
> this might as well not be an optimization, but pessimization ...

If we do not expect the linker to do merging, then we should
reference count the strings.

> Would it suffice to put the predicate AT_string_indirect() into a separate
> inline function and use it in all the places where this distinction is
> needed?

Yes.


r~



More information about the Gcc-patches mailing list