[PATCH] adds powerpc-*-freebsd? to mainline

[Geoff Keating]

> Date: Tue, 13 Nov 2001 12:42:46 -0800
> From: "David O'Brien" <obrien@FreeBSD.org>
> Cc: gcc-patches@gcc.gnu.org

> On Tue, Nov 13, 2001 at 02:06:46AM -0800, Geoff Keating wrote:
> > > --- elfos.h	2001/11/11 05:56:38	1.36
> > > +++ elfos.h	2001/11/12 21:53:27
> > > -#define USING_ELFOS_H
> > > +#define _USING_ELFOS_H
> > 
> > This is not OK.  Why make this change?  
> 
> Just to be the same in mainline and 3.0_branch.

You mean, you were trying to import a patch from the branch to the
mainline?  That's not the right way to do it, it should only go the
other way; generally, the branch has more bugs and fewer features than
the mainline.

> > Symbols starting with an
> > underscore and an uppercase letter are reserved for the
> > implementation.
> 
> Yes.  I sometimes forget that GCC is not the system (implementation)
> compiler everywhere.

Even if GCC is the system compiler, elfos.h is not a system header,
so it shouldn't use namespace reserved for the system.

> Does this mean that other than this part of the patch, you are OK with my
> patch and it is OK to commit it?

No, not least because without that change it won't work; please re-submit.

-- 
- Geoffrey Keating <geoffk@geoffk.org> <geoffk@redhat.com>