Unreviewed patches

Daniel Berlin dan@cgsoftware.com
Fri Nov 2 18:17:00 GMT 2001



On Mon, 12 Nov 2001, Jakub Jelinek wrote:

> Hi!
>
> http://gcc.gnu.org/ml/gcc-patches/2001-10/msg01300.html
> 	- fix endless loop with bogus C array initializer
> http://gcc.gnu.org/ml/gcc-patches/2001-10/msg00898.html
> 	- fix ICE handling anonymous union on Alpha/Sparc/...
> http://gcc.gnu.org/ml/gcc-patches/2001-10/msg01218.html
> 	- fix store motion (although Dan Berlin claims
> 	store motion should be disabled altogether ATM,
> 	IMHO this patch should be applied nevertheless)

I agree, BTW, as it's *part* of a correct fix, but nowhere near complete.

The list of problems with store motion, off the top of my head:
1. store_ops_ok returns the opposite value it should (IE 0 when should
be 1, 1 when  should be 0) for registers.
2. Constant calls are not handled properly.
3. memory that can alias anything is not handled properly (it doesn't
notice that stores that alias anything kill your current store, as well as
loads from memory that alias anything)
These are just the bugs off the top of my head, while trying to pay
attention in criminal law class.

--Dan



More information about the Gcc-patches mailing list