AIX 5.1 on IA-64 patches

Jim Wilson wilson@cygnus.com
Fri May 25 12:03:00 GMT 2001


This isn't a properly formatted ChangeLog entry.

The fixinc changes aren't mentioned in the ChangeLog entry.

Is there any reason why the AIX unwind functions were put in the unwind-ia64.c
file instead of in their own file like was done for linux?  I think putting
them in their own file is cleaner.

I see nothing justifying why you have replaced the AIX va_list.h.

The CPP_PREDEFINES macro is missing a \ on one line.

Some of the macros near the end of aix.h are badly formatted.  In particular,
SELECT_SECTION, UNIQUE_SECTION, ASM_OUTPUT_SECTION_NAME.  The last one is
badly formatted that many of the trailing \ character appear on a line by
themselves.

Otherwise, it seems reasonable clean, since it is mostly adding new files
which are AIX specific, and the contents of those files aren't critical at
this time.  There is only the one fixinc patch that affects a shared file.

I am willing to approve this for mainline after the above stuff is fixed.

There is a conflict with a clean up patch proposed by David O'Brien, but
we could deal with that after the AIX support goes in.  I think we need to
have all 3 OS support files in there before we can really do the cleanup work
properly anyways.

As for the gcc-3 branch, IA-64 work has been keeping me so busy that I haven't
been able to follow the gcc-3 release stuff closely.  There are enough
argumentative and disagreeable people involved that I don't feel confortable
approving patches at this time unless I have a very good understanding of
the patch.  I've never worked with fixinc, so I don't know that part well
enough to approve it for gcc-3.  I am willing to approve the rest of the
patch for gcc-3 after the above stuff is fixed.

Jim



More information about the Gcc-patches mailing list