[PATCH] Remove dead cruft from crtstuff.c (take 2)

[H . J . Lu]

On Fri, Mar 16, 2001 at 06:08:16PM +0100, Jakub Jelinek wrote:
> On Fri, Mar 16, 2001 at 07:51:07AM -0800, H . J . Lu wrote:
> > On Fri, Mar 16, 2001 at 12:01:31PM +0100, Jakub Jelinek wrote:
> > > Hi!
> > > 
> > > As result of recent atexit changes in glibc using atexit in i386-linux
> > > crtendS.o is bad (since if the shared library does not use atexit, it won't
> > > be taken from libc_nonshared and shared library will thus end up with
> > > non-versioned atexit reference).
> > > According to H.J., this kludge was needed only for very very old Linux C
> > > libraries and can be safely killed.
> > > Ok to commit?
> > > 
> > 
> > How about this patch? The old libc still needs it.
> 
> In that case, isn't it better to move it out of crtstuff.c into target
> headers?
> 
> 2001-03-16  Jakub Jelinek  <jakub@redhat.com>
> 
> 	* crtstuff.c (init_dummy): Use CRT_END_INIT_DUMMY if defined.
> 	Remove ia32 linux PIC kludge and move it...
> 	* config/i386/linux.h (CRT_END_INIT_DUMMY): ...here.
> 

Looks fine to me. Please mention "old" i386 GNU/Linux dynamic linker.

BTW, I assume have done "make" and "make check" on glibc with the
new gcc.

Thanks.


H.J.