Fix thinko in params

Daniel Berlin dan@cgsoftware.com
Tue Jun 26 08:33:00 GMT 2001


Kelley Cook <Kelley.Cook@home.com> writes:

> Hi Dan,
> 
>>diff -c -3 -p -w -B -b -r1.680 Makefile.in
>>*** Makefile.in	2001/06/20 07:18:11	1.680
>>--- Makefile.in	2001/06/26 05:03:52
>>*************** TM_P_H = tm_p.h $(tm_p_file_list) insn-c
>>*** 557,562 ****
>>--- 557,563 ----
>>  MACHMODE_H = machmode.h machmode.def
>>  RTL_BASE_H = rtl.h rtl.def $(MACHMODE_H)
>>  RTL_H = $(RTL_BASE_H) genrtl.h
>>+ $(PARAMS_H) = $(PARAMS_H) params.def
> 
> Shouldn't this hunk be:
> 
>+ PARAMS_H = params.h params.def
> 
> otherwise params.h is now left out of the loop, since it is otherwise never 
> mentioned in any of the configuration or makefiles.
Yes yes, My bad.
I have it right in my real Makefile.in, which has other changes in it,
and thus, I moved it out of the way and redid the search/replace on a
clean version.

> 
> Secondly, because this new "PARAMS_H" definition matches the define already
> present in params.h, for clarity, it might be prudent to add the header 
> guard that is in the mainline params.h to the branch.
Okey.

> 
> Thanks,
> Kelley Cook
> 
> ===================================================================
> RCS file: /cvs/gcc/gcc/gcc/params.h,v
> retrieving revision 1.3.2.3
> retrieving revision 1.6
> diff -c -b -r1.3.2.3 -r1.6
> *** gcc/gcc/params.h	2001/05/01 18:56:22	1.3.2.3
> --- gcc/gcc/params.h	2001/05/26 01:31:34	1.6
> ***************
> *** 32,39 ****
>      Since their values can be set on the command-line, these parameters
>      should not be used for non-dynamic memory allocation.  */
>   
> ! #ifndef PARAMS_H
> ! #define PARAMS_H
>   
>   /* No parameter shall have this value.  */
>   
> --- 32,39 ----
>      Since their values can be set on the command-line, these parameters
>      should not be used for non-dynamic memory allocation.  */
>   
> ! #ifndef GCC_PARAMS_H
> ! #define GCC_PARAMS_H
>   
>   /* No parameter shall have this value.  */
>   
> ***************
> *** 93,96 ****
>   #define MAX_GCSE_MEMORY \
>     ((size_t) PARAM_VALUE (PARAM_MAX_GCSE_MEMORY))
>   
> ! #endif /* PARAMS_H */
> --- 93,96 ----
>   #define MAX_GCSE_MEMORY \
>     ((size_t) PARAM_VALUE (PARAM_MAX_GCSE_MEMORY))
>   
> ! #endif /* ! GCC_PARAMS_H */
> 
> 

-- 
"While I was gone, somebody rearranged all the furniture in my
bedroom.  They put it in *exactly* the same place it was.  When
I told my roommate, he said:  "Do I know you?"
"-Steven Wright



More information about the Gcc-patches mailing list