[v3] typos in comments, updates, target_alias in configure.in
Phil Edwards
pedwards@disaster.jaj.com
Mon Jun 11 05:37:00 GMT 2001
This patches some comments in acinclude.m4, updates a bit of the README,
and -- need approval for this part -- adds a possibly-redundant AC_SUBST
in configure.in that's needed in autoconf 2.50.
In 2.13 target_alias was always set and subst'd even when the user didn't
specify a target by hand. In 2.50, it's only there if the user says so.
However, we use it all over the place. So we need to make certain that
it has a value and that the value is subst'd. (Alexandre sanity-checked
me on this already.) For 2.13-generated configure's, this doesn't hurt.
There's a couple other 2.50-related changes in my local tree, but those
must wait until after Friday. And I suspect many of the People In Charge
will not have recovered from the hangovers until next Wednesday, so I
won't post them until after then. :-)
Okay to commit?
Index: acinclude.m4
===================================================================
RCS file: /home/pme/Repositories/GCC/gcc/libstdc++-v3/acinclude.m4,v
retrieving revision 1.155
diff -u -3 -r1.155 acinclude.m4
--- acinclude.m4 2001/06/11 04:36:55 1.155
+++ acinclude.m4 2001/06/11 11:07:18
@@ -1,8 +1,6 @@
dnl
dnl Initialize configure bits.
dnl
-dnl Define OPTLEVEL='-O2' if new inlining code present.
-dnl
dnl GLIBCPP_CONFIGURE
AC_DEFUN(GLIBCPP_CONFIGURE, [
dnl Default to --enable-multilib
@@ -172,9 +80,9 @@
dnl
-dnl Test for newer compiler features, or features that are present in newer
-dnl compiler version but not older compiler versions should be placed
-dnl here.
+dnl Tests for newer compiler features, or features that are present in newer
+dnl compiler versions but not older compiler versions still in use, should
+dnl be placed here.
dnl
dnl Define WERROR='-Werror' if requested and possible; g++'s that lack the
dnl new inlining code or the new system_header pragma will die on -Werror.
@@ -186,7 +94,7 @@
dnl GLIBCPP_CHECK_COMPILER_FEATURES
AC_DEFUN(GLIBCPP_CHECK_COMPILER_FEATURES, [
# All these tests are for C++; save the language and the compiler flags.
- # The CXXFLAGS thing is suspicious, but based on similar bits
+ # The CXXFLAGS thing is suspicious, but based on similar bits previously
# found in GLIBCPP_CONFIGURE.
AC_LANG_SAVE
AC_LANG_CPLUSPLUS
@@ -362,7 +270,7 @@
dnl
dnl Check to see if the (math function) argument passed is
dnl declared when using the c++ compiler
-dnl ASSUMES argument is a math function with ONE parameter
+dnl ASSUMES argument is a math function with TWO parameters
dnl
dnl GLIBCPP_CHECK_MATH_DECL_2
AC_DEFUN(GLIBCPP_CHECK_MATH_DECL_2, [
@@ -408,7 +316,7 @@
dnl
dnl Check to see if the (math function) argument passed is
dnl declared when using the c++ compiler
-dnl ASSUMES argument is a math function with ONE parameter
+dnl ASSUMES argument is a math function with THREE parameters
dnl
dnl GLIBCPP_CHECK_MATH_DECL_3
AC_DEFUN(GLIBCPP_CHECK_MATH_DECL_3, [
Index: README
===================================================================
RCS file: /home/pme/Repositories/GCC/gcc/libstdc++-v3/README,v
retrieving revision 1.8
diff -u -3 -r1.8 README
--- README 2001/04/06 01:47:11 1.8
+++ README 2001/06/04 03:49:09
@@ -62,10 +62,11 @@
Test programs are here, and may be used to begin to exercise the
library. Support for "make check" and "make check-install" is
complete, and runs through all the subdirectories here when this
- command is issued from the build directory. Please note that
- "make check" calls the script mkcheck, which requires bash, and which
- may need the paths to bash adjusted to work properly, as /bin/bash is
- assumed.
+ command is issued from the build directory. Please note that
+ "make check" requires DejaGNU 1.4 or later to be installed. Please
+ note that "make check-script" calls the script mkcheck, which
+ requires bash, and which may need the paths to bash adjusted to
+ work properly, as /bin/bash is assumed.
Other subdirectories contain variant versions of certain files
that are meant to be copied or linked by the configure script.
Index: configure.in
===================================================================
RCS file: /home/pme/Repositories/GCC/gcc/libstdc++-v3/configure.in,v
retrieving revision 1.63
diff -u -3 -r1.63 configure.in
--- configure.in 2001/06/01 09:22:05 1.63
+++ configure.in 2001/06/01 21:13:32
@@ -33,7 +33,11 @@
ifelse(not,equal,[AC_CONFIG_AUX_DIR(..)])
# Gets and sets build, host, target, *_vendor, *_cpu, *_os, etc.
+# AC 2.50 sets target_alias iff the user specified --target, but we use it
+# everywhere, so we set it here just to be sure.
AC_CANONICAL_SYSTEM
+target_alias=${target_alias-$target}
+AC_SUBST(target_alias)
# We use these options to decide which functions to include.
AC_ARG_WITH(target-subdir,
More information about the Gcc-patches
mailing list