[PATCH] Only emit read_encoded_value into unwind-dw2.c

Franz Sirl Franz.Sirl-kernel@lauterbach.com
Tue Jul 24 02:15:00 GMT 2001


At 10:54 23.07.2001, Jakub Jelinek wrote:
>On Sun, Jul 22, 2001 at 12:39:06PM -0700, Richard Henderson wrote:
> > On Sun, Jul 22, 2001 at 06:37:46PM +0200, Jakub Jelinek wrote:
> > > unwind-dw2.o should not make it into libc.so, but apparently 
> something (most
> > > probably unwind-dw2-fde.o) drags it in.
> >
> > It's almost certainly base_of_encoded_value from unwind-pe.h,
> > which is not actually used in unwind-dw2-fde.c.  Some of the
> > other routines from that header are though.
>
>Yeah, that's what happens.
>Below are two possible patches (depends on why is read_encoded_value in
>unwind-pe.h). The first one just moves base_of_encoded_value and
>read_encoded_value into unwind-dw2.c which is the only user, the latter
>keeps it in unwind-pe.h protected by #define. Or do you suggest something
>else?

Jakub, P2 works for me with the changes Mark suggested (#ifdef 
WANT_READ_ENCODED_VALUE -> #ifndef AVOID_READ_ENCODED_VALUE). I rebuilt gcc 
and then glibc, both compile and work fine now, thanks.

Franz.





More information about the Gcc-patches mailing list