gcc told me to report a bug

Nicola Pero nicola@brainstorm.co.uk
Thu Dec 6 02:51:00 GMT 2001


> > -
> > +  else if (code == ENUMERAL_TYPE)
> > +    {
> > +      charType = 'i';
> > +    }
> >    else
> > -    abort ();
> > +    {
> > +      abort ();
> > +    }
> 
> I'm picking nits, but the GNU coding standards mandate no braces here.
> Since the rest of GCC follows this pretty well, I'd appreciate it if
> your patch did too.

Ok - fine - I'll avoid the braces here - 

+ else if (code == ENUMERAL_TYPE) 
+   charType = 'i';

(picking nits myself, I don't think the GNU coding standards particularly
enforce that it's forbidden to put braces there :-) - they certainly say
they are compulsory in other cases :-) - but I don't think it really
matters - if the rest of GCC doesn't use braces in these cases, you're
right I should follow the GCC convention.)



More information about the Gcc-patches mailing list