rs6000 -fdata-sections

Geoff Keating geoffk@geoffk.org
Wed Dec 5 11:26:00 GMT 2001


> Date: Wed, 5 Dec 2001 14:00:36 +1030
> From: Alan Modra <amodra@bigpond.net.au>

> On Tue, Dec 04, 2001 at 03:17:46PM -0800, Geoff Keating wrote:
> > 
> > I'd appreciate it if you could leave 'prefixes' as a two-dimensional
> > array, and leave the definitions of 'readonly' and 'needs_sdata', as
> > both of these provide important documentation; I'm really not a big
> > fan of the huge 'if ((x && a) || (y && b) || (z && (d || e)))'
> > conditions.  Rewriting the assignment to 'sec' as a sequence of
> > if-then conditions is good.  Can you submit a revised patch along
> > those lines?
> 
> I'll take the liberty of interpreting your request regarding "readonly"
> loosely.  How's this?

Not OK; I meant that the word 'readonly' provides important
documentation about the meaning of the condition being tested, please
don't remove it.

-- 
- Geoffrey Keating <geoffk@geoffk.org> <geoffk@redhat.com>



More information about the Gcc-patches mailing list