[PATCH]: realloc insn table in df_modify_insn, if necessary

Daniel Berlin dan@cgsoftware.com
Mon Aug 27 11:11:00 GMT 2001


law@redhat.com writes:

>   In message < 87wv3qzwyr.fsf@cgsoftware.com >you write:
>   > This is obvious, and has been committed.
>   > 
>   > It's necessary because with out, df_insn_modify will crash when doing
>   > incremental updates.
>   > 
>   > 2001-08-26  Daniel Berlin  <dan@cgsoftware.com>
>   >  
>   > 	* df.c (df_insn_modify): Realloc the INSN table here, if
>   > 	necessary, here, too.
> I consider this *far* from obvious.
>
> Under precisely what conditions did you end up with a UID outside the
> range that the DF analyzer knows about?
Easy.
Call df_insn_modify on a new insn.
"If the dataflow information requires updating then all the changed,
new, or deleted insns needs to be marked with df_insn_modify".
It never reallocs the table unless it emitted the insn, and called an
internal function.
Which is clearly wrong.

Just as you've worked more with GCSE than I have, i've worked more on
the df analyzer than you have.



>
> jeff
>
>
>

-- 
"Last night, I walked up to this beautiful woman in a bar and
asked her, "Do you live around here often?"  She said, "You're
wearing two different colored socks."  I said, "Yes, but to me
they're the same because I go by thickness."  Then she asked,
"How do you feel?"  and I said, "Well, you know when you're
sitting on a chair and you lean back so you're just on two legs
then you lean too far and you almost fall over but at the last
second you catch yourself?  I feel like that all the time."
"-Steven Wright



More information about the Gcc-patches mailing list