Patch to use concat instead of xmalloc/sprintf for JAVA dir
Richard Henderson
rth@redhat.com
Mon Apr 23 14:38:00 GMT 2001
On Sun, Apr 22, 2001 at 08:11:05AM -0400, Kaveh R. Ghazi wrote:
> The xmalloc length calculates enough space for the two strings, the
> "-f" and the "=" (i.e. +3) but not for the trailing NULL.
Actually, it appears to be ok:
> - sprintf (patharg, "-f%s=%s", argv[i]+1, argv[i+1]);
^^
It would have been clearer with that +1 in the strlen argument
as well, with an additional +1 to the constant.
Anyhow, concat is the Correct solution.
r~
More information about the Gcc-patches
mailing list