[patch] args to genmultilib needs to be protected

Ben Collins bcollins@debian.org
Mon Apr 23 10:45:00 GMT 2001


On Mon, Apr 23, 2001 at 01:41:49PM -0400, DJ Delorie wrote:
> 
> > +	  "`test @enable_multilib@ = yes && echo '$(MULTILIB_OPTIONS)'`" \
> 
> The quote combo bothers me.  I can imagine things that get quoted one
> way with '' and another way with "", and we've historically had
> problems with re-quoting things.
> 
> Perhaps we should move the test outside the command, like this?  It
> should be faster, too.
> 
> s-mlib: $(srcdir)/genmultilib Makefile
> 	if test @enable_multilib@ = yes; \
> 	  $(SHELL) $(srcdir)/genmultilib \
> 	  '$(MULTILIB_OPTIONS)' '$(MULTILIB_DIRNAMES)' ... > /tmp/mlib.h ;\
> 	else \
> 	  $(SHELL) $(srcdir)/genmultilib > /tmp/mlib.h ;\
> 	fi

That does make much more sense, and solves the problem.

-- 
 -----------=======-=-======-=========-----------=====------------=-=------
/  Ben Collins  --  ...on that fantastic voyage...  --  Debian GNU/Linux   \
`  bcollins@debian.org  --  bcollins@openldap.org  --  bcollins@linux.com  '
 `---=========------=======-------------=-=-----=-===-======-------=--=---'



More information about the Gcc-patches mailing list