[patch] args to genmultilib needs to be protected

DJ Delorie dj@redhat.com
Mon Apr 23 10:41:00 GMT 2001


> +	  "`test @enable_multilib@ = yes && echo '$(MULTILIB_OPTIONS)'`" \

The quote combo bothers me.  I can imagine things that get quoted one
way with '' and another way with "", and we've historically had
problems with re-quoting things.

Perhaps we should move the test outside the command, like this?  It
should be faster, too.

s-mlib: $(srcdir)/genmultilib Makefile
	if test @enable_multilib@ = yes; \
	  $(SHELL) $(srcdir)/genmultilib \
	  '$(MULTILIB_OPTIONS)' '$(MULTILIB_DIRNAMES)' ... > /tmp/mlib.h ;\
	else \
	  $(SHELL) $(srcdir)/genmultilib > /tmp/mlib.h ;\
	fi



More information about the Gcc-patches mailing list