Fixed build failure on Linux in cppfiles (_XOPEN_SOURCE is evil)

Alexandre Oliva aoliva@redhat.com
Sat Sep 16 10:36:00 GMT 2000


On Sep 16, 2000, Mark Mitchell <mark@codesourcery.com> wrote:

> We don't have any way of knowing what these macros are doing on
> non-glibc based systems.

Odds are that _GNU_SOURCE is going to be ignored.  _XOPEN_SOURCE,
OTOH, may have all sorts of weird effects.

Maybe the way to go is to define _XOPEN_SOURCE conditionally and, if
it is defined, to decide whether to define _BSD_SOURCE and _GNU_SOURCE
too.

> Defining these macros unconditionally on all systems is a mistake.

Agreed.  I just approved the patch to get the tree in a buildable
state again, at least on GNU/Linux.

I think we could leave the tree as is for the next snapshot and see
what breaks, then decide our next step.

-- 
Alexandre Oliva   Enjoy Guarana', see http://www.ic.unicamp.br/~oliva/
Red Hat GCC Developer                  aoliva@{cygnus.com, redhat.com}
CS PhD student at IC-Unicamp        oliva@{lsd.ic.unicamp.br, gnu.org}
Free Software Evangelist    *Please* write to mailing lists, not to me


More information about the Gcc-patches mailing list