SH PIC: use TARGET_SH2 instead of ! TARGET_SH1

Alexandre Oliva aoliva@redhat.com
Fri Oct 6 11:04:00 GMT 2000


Part of some `call' expands introduced with the SH PIC patches contain
a bug that went undetected so far.  The problem is that `! TARGET_SH1'
would only trigger in case `-m1' is given explicitly in the command
line, but, on sh-elf, even though SH1 code is generated by default,
TARGET_SH1 isn't set.  That's not the case for sh-linux, because it
generates SH3 code by default.

While I was at it, I decided to add `{}'s around the whole block, just
for uniformity.

But now that I look into it, I can't think of any reason why those PIC
call sequences can't be used on SH1.  Can anybody?

Meanwhile, I'm checking this in, pre-approved by Joern Rennecke
(actually, he approved just the change in content; I'm checking in the
reformatting under the obviously-correct rule).



More information about the Gcc-patches mailing list