[PATCH] Revised BeOS libstdc++ patch

Daniel Berlin dberlin@cygnus.com
Fri Nov 24 12:54:00 GMT 2000


On Fri, 24 Nov 2000, Jason Merrill wrote:

> >>>>> "Daniel" == Daniel Berlin <dberlin@cygnus.com> writes:
> 
> > Here's the real patch I meant to submit, including rth's suggested use of 
> > making _Atomic_swap i386 specific, rather than BeOS specific.
> 
> > Really, it should be in atomicity.h, but that's not my call.
> 
> I strongly agree.  I find the STL headers to be far too #ifdef-heavy
> for my taste; I much prefer the GCC approach to portability.
> 
> But you also seem to be introducing platform #ifdef-ery into files
> that aren't already (so) polluted: _G_config.h and gen-num-limits.cc.
> Is there a reason those changes can't use stuff defined in one of the
> config files?
These are temporary changes.

I wanted to submit the patches while they applied, rather than let them 
languish, since I expect libstdc++-v3 will receive a lot of patches in 
the next few weeks as new platforms port to it.

Hopefully, I can make the gen-num-limits.cc #ifdef into somethin gother 
than __BEOS__ (like #ifdef SIGNAL_HANDLING_VERY_STUPID, I guess), so we 
can detect the platforms.

I should be able to make the _G_config.h change use a configure test as well.

I'm shooting to have these both happen in the next week.

--Dan


More information about the Gcc-patches mailing list