RFA: Unterminated string constants in m88k.h
Nick Clifton
nickc@redhat.com
Sun Nov 5 12:58:00 GMT 2000
Hi Guys,
There appears to be a couple of unterminated string constants in
m88k.h. They are in macros, where the string ends with \" rather
than " or \t".
The patch below fixes these with what I hope was the author's
intentions, but I am not 100% sure, so rather than commit it under
the obvious fix rule, I am seeking approval.
OK to commit ?
Cheers
Nick
2000-11-05 Nick Clifton <nickc@redhat.com>
* config/m88k/m88k.h (GLOBAL_ASM_OP): Add missing tab.
(INTERNAL_ASM_OP): Add missing tab.
Index: config/m88k/m88k.h
===================================================================
RCS file: /cvs/gcc/egcs/gcc/config/m88k/m88k.h,v
retrieving revision 1.28
diff -p -r1.28 m88k.h
*** m88k.h 2000/09/25 13:22:46 1.28
--- m88k.h 2000/11/05 20:53:12
*************** enum reg_class { NO_REGS, AP_REG, XRF_RE
*** 1719,1725 ****
#define FILE_ASM_OP "\tfile\t"
#define SECTION_ASM_OP "\tsection\t"
#define SET_ASM_OP "\tdef\t"
! #define GLOBAL_ASM_OP "\tglobal\"
#define ALIGN_ASM_OP "\talign\t"
#define SKIP_ASM_OP "\tzero\t"
#define COMMON_ASM_OP "\tcomm\t"
--- 1719,1725 ----
#define FILE_ASM_OP "\tfile\t"
#define SECTION_ASM_OP "\tsection\t"
#define SET_ASM_OP "\tdef\t"
! #define GLOBAL_ASM_OP "\tglobal\t"
#define ALIGN_ASM_OP "\talign\t"
#define SKIP_ASM_OP "\tzero\t"
#define COMMON_ASM_OP "\tcomm\t"
*************** enum reg_class { NO_REGS, AP_REG, XRF_RE
*** 1753,1759 ****
fputc ('\n', FILE); } while (0)
/* These are specific to version 03.00 assembler syntax. */
! #define INTERNAL_ASM_OP "\tlocal\"
#define VERSION_ASM_OP "\tversion\t"
#define UNALIGNED_SHORT_ASM_OP "\tuahalf\t"
#define UNALIGNED_INT_ASM_OP "\tuaword\t"
--- 1753,1759 ----
fputc ('\n', FILE); } while (0)
/* These are specific to version 03.00 assembler syntax. */
! #define INTERNAL_ASM_OP "\tlocal\t"
#define VERSION_ASM_OP "\tversion\t"
#define UNALIGNED_SHORT_ASM_OP "\tuahalf\t"
#define UNALIGNED_INT_ASM_OP "\tuaword\t"
More information about the Gcc-patches
mailing list