Fix for makefile bug - tests regardless of what was built
Jeffrey A Law
Tue Mar 14 12:45:00 GMT 2000
In message < 38C1DA27.883D71D2@melbpc.org.au >you write:
> Currently if you type "make check" the makefile tries to test
> every language, even programs that weren't copnfigured. This
> patch chanegs the behaviour so that only C plus any other
> languages that were configured will get tested. This was just a
> matter of moving the makefile fragments into the Make-lang
> fragments for the relevant languages.
This sounds like a good thing to fix. A few comments on the patch:
> ---------------->>> here are the diffs
> diff -Nrc3p egcs-20000228/gcc/ChangeLog
> *** egcs-20000228/gcc/ChangeLog Wed Mar 1 19:33:24 2000
> --- egcs-20000228.new/gcc/ChangeLog Wed Mar 1 19:59:06 2000
> *** 1,3 ****
> --- 1,8 ----
> + Wed 1 Mar 20:07:03 2000 Tim Josling <firstname.lastname@example.org>
> + * moved tests (check:, check-*) to Make-lang.in for each
> + other than C.
Do not send ChangeLog entries as diffs. Send them as plaintext.
The format of a ChangeLog entry is
<tab> * filename (function name or make target): What changed.
Please change your ChangeLog entries to conform to proper standards.
> ! #CHECK_TARGETS = check-gcc check-g++ check-g77 check-objc
Go ahead and remove this line completely.
> ! # other targets than C moved to Make-lang.in for each target
I think this would be better
# For targets other than C, the check targets are contained in the Make-lang.in
# Makefile fragments.
Can you please make those changes and resubmit your patch?
More information about the Gcc-patches