Help strings for vax options.

Kaveh R. Ghazi ghazi@caip.rutgers.edu
Sat Jun 24 11:10:00 GMT 2000


 > From: Philipp Thomas <pthomas@suse.de>
 > 
 > Here's a patch from John David Anglin providing help for vax options.
 > OK to check in? BTW, does something like this fall under the
 > 'obvious fix' rule? I wasn't sure.

IMO, yes.

Its completely compile-time sanity checked, so you can build toplev.o
in a cross-compiler targetting a vax if you want to double check no
typos were introduced.

BTW, the last line with TARGET_DEFAULT probably invokes a "missing
initializer" warning.  Can you please add a zero (or NULL) while your
hands are in there?

NIT: the ChangeLog entry should probably be:

 > 	* vax.h (TARGET_SWITCHES): Provide descriptions.

Target files omit "config" and cpu-dir if its the same as the header
file name.  (Though not everybody follows this.)  Also you need a
space after * and before (.

		Thanks,
		--Kaveh

 > 
 > 
 > 2000-06-22  John David Anglin  <dave.anglin@nrc.ca>
 > 	*config/vax/vax.h(TARGET_SWITCHES): Provide descriptions.
 > 
 > --- vax.h.orig	Tue Jun 13 13:30:19 2000
 > +++ vax.h	Thu Jun 22 14:10:54 2000
 > @@ -67,13 +67,13 @@
 >     An empty string NAME is used to identify the default VALUE.  */
 >  
 >  #define TARGET_SWITCHES  \
 > -  { {"unix", 1},  \
 > -    {"gnu", -1},  \
 > -    {"vaxc-alignment", 2}, \
 > -    {"g", 4}, \
 > -    {"g-float", 4}, \
 > -    {"d", -4},	\
 > -    {"d-float", -4}, \
 > +  { {"unix", 1, "Generate code for UNIX assembler"},  \
 > +    {"gnu", -1, "Generate code for GNU assembler (gas)"},  \
 > +    {"vaxc-alignment", 2, "Use VAXC structure conventions"}, \
 > +    {"g", 4, "Generate GFLOAT double precision code"}, \
 > +    {"g-float", 4, "Generate GFLOAT double precision code"}, \
 > +    {"d", -4, "Generate DFLOAT double precision code"},	\
 > +    {"d-float", -4, "Generate DFLOAT double precision code"}, \
 >      { "", TARGET_DEFAULT}}
 >  
 >  /* Default target_flags if no switches specified.  */


More information about the Gcc-patches mailing list