PATCH: SSA for hard registers

Jeffrey A Law law@cygnus.com
Mon Jul 31 18:33:00 GMT 2000


  In message < 20000731175642.A7481@cygnus.com >you write:
  > On Mon, Jul 31, 2000 at 10:35:46AM -0700, Mark Mitchell wrote:
  > > + /* We cannot use <assert.h> in GCC source, since that would include
  > > +    GCC's assert.h, which may not be compatible with the host compiler. 
  >  */
  > > + #undef assert
  > > + #ifdef NDEBUG
  > > + # define assert(e)
  > > + #else
  > > + # define assert(e) do { if (! (e)) abort (); } while (0)
  > > + #endif
  > 
  > The entire rest of the source base uses `if (!e) abort()';
  > I don't see that we should make an exception here.
Agreed.  The standard is to use

  if (can't happen)
    abort ();

Unless there's a complelling reason I think we should stick with
that coding standard.

jeff


More information about the Gcc-patches mailing list