PATCH: Add 1750a-protos.h file

Jeffrey A Law law@cygnus.com
Wed Jan 12 19:07:00 GMT 2000


  In message < 200001130030.TAA19476@caip.rutgers.edu >you write:
  > Tested by building cc1 configured as an i686-pc-linux-gnu ->
  > 1750a-unknown-none cross compiler.
  > 
  > Note to the reviewer:
  > 
  > Check out the changes to ASM_OUTPUT_REG_PUSH and ASM_OUTPUT_REG_POP.
  > These macros had calls to fprintf which were missing arguments based
  > on the format specifier.  I just copied the previous string argument,
  > this is probably wrong so please double check and supply the right
  > answer.  I'm sometimes amazed that gcc ever works.  :-)
Well, I'm not sure if anyone here is familiar with the 1750a.

My recommendation is to make one of the operands a string that is highly
unlikely to properly assemble.  Then if someone builds this port and that
code gets triggered, they'll get an assembly time error.  It's better
than the pseudo-random situation we're in with that code right now.


  > 
  > Okay to install?
  > 
  > 		--Kaveh
  > 
  > 
  > 2000-01-12  Kaveh R. Ghazi  <ghazi@caip.rutgers.edu>
  > 
  > 	* 1750a-protos.h: New file.
  > 
  > 	* 1750a.c: Include tm_p.h.  Add static prototypes.  Fix compile
  > 	time warnings.
  > 	
  > 	* 1750a.h: Move prototypes to 1750a-protos.h.  Fix compile time
  > 	warnings.
  > 	
  > 	* 1750a.md: Likewise.
Fine with the ASM_OUTPUT_REG_{PUSH,POP} tweaks noted above.
jeff



More information about the Gcc-patches mailing list