PATCH: gcc/config/pa/pa-protos.h and prototype fixes

[Brown, Rodney]

Title: RE: PATCH: gcc/config/pa/pa-protos.h and prototype fixes





I've already done rs6000, with some extra warning elimination stuff - but
one regression in the C language tests. 
I'll look into that a bit more but may need a hand fixing it.
Surprisingly C++ seems to have better results.
This may just be timeouts since my RS6000 is RIOS1 20MHz - will get
back to you.


If the intent is for PARAMS to be standard (cf PROTOS)
that at least within config/architecture directories to convert over as patches
are needed (pa.c - since the pa-protos you have is using PARAMS).


enum machine_mode has 1960 references in 117 files,
1118 in 54 files in gcc/config.
v850/v850-protos.h uses a #define Mmode enum machine_mode
Would a typedef be worthwhile (in the fullness of time)?


> -----Original Message-----
> From: Kaveh R. Ghazi [ mailto:ghazi@caip.rutgers.edu ]
> Sent: Monday, 10 January 2000 12:39
> To: gcc-patches@gcc.gnu.org; rodneybrown@pmsc.com
> Cc: law@cygnus.com
> Subject: Re: PATCH: gcc/config/pa/pa-protos.h and prototype fixes
> 
> 
>  > From: "Brown, Rodney" <rodneybrown@pmsc.com>
>  > 
>  > The substantive changes have been tested on hppa1.1-hpux11.0 and
>  > hppa2.0-hpux10.20
>  > with no testsuite regressions. I didn't rebuild after the 
> following change
>  > to config/pa/pa.c
>  > -static void pa_combine_instructions          PARAMS((rtx i
>  > ATTRIBUTE_UNUSED));
>  > +static void pa_combine_instructions          PARAMS((rtx 
> /*UNUSED*/));
>  > 
>  > The change to the symbolic_operand call in config/pa/pa.md and the
>  > change to the constrain_operands call in config/pa/pa.c should
>  > change the generated code.  If the pa-protos.h file doesn't
>  > constitute a minor change, I'm not yet copyright assigned.
> 
> Doh!  Independently, I just did a similar patch today.
> 
> I'm copyright assigned, so if its an issue, maybe we can start with
> mine and add anything extra you've got.
> 
>               Thanks,
>               --Kaveh
> 
> PS: I plan on doing more and I'd like to avoid duplication, are you
> working on any other *-protos.h files?  (Or have you already?)
> 
> --
> Kaveh R. Ghazi                        Engagement Manager / 
> Project Services
> ghazi@caip.rutgers.edu                Qwest Internet Solutions
>