Committed: fix typo in ns32k.md (was: Re: instruction not recognized (genrecog bug?))

Hans-Peter Nilsson hans-peter.nilsson@axis.com
Sun Jan 9 08:22:00 GMT 2000


> From: Ian Dall <ian@beware.dropbear.id.au>
> Date: Mon, 10 Jan 2000 01:23:53 +1030 (CST)

> The interesting thing is that this seems to me like a bug in genrecog.c
> There is an insn in the ns32k.md which should match as far as I can see:
> 
> (define_insn ""
>   [(set (match_operand:SI 0 "general_operand" "=g<")
>         (match_operand:QI 1 "address_operand" "p"))]

No, there's a typo in that pattern; operands 0 and 1 must have
the same mode.  Since the typo is IMHO obvious, I installed this
patch:

Sun Jan  9 17:50:23 2000  Hans-Peter Nilsson  <hp@axis.com>

	* config/ns32k/ns32k.md (load or push effective address): Operand 1
	must have SImode.

Index: config/ns32k/ns32k.md
===================================================================
RCS file: /cvs/gcc/egcs/gcc/config/ns32k/ns32k.md,v
retrieving revision 1.9
diff -p -c -r1.9 ns32k.md
*** ns32k.md	1999/10/15 06:38:02	1.9
--- ns32k.md	2000/01/09 16:08:48
***************
*** 1,5 ****
  ;;- Machine description for GNU compiler, ns32000 Version
! ;;  Copyright (C) 1988, 1994, 1996, 1998, 1999 Free Software Foundation, Inc.
  ;;  Contributed by Michael Tiemann (tiemann@cygnus.com)
  
  ;; This file is part of GNU CC.
--- 1,5 ----
  ;;- Machine description for GNU compiler, ns32000 Version
! ;;  Copyright (C) 1988, 1994, 1996, 1998-99, 2000 Free Software Foundation, Inc.
  ;;  Contributed by Michael Tiemann (tiemann@cygnus.com)
  
  ;; This file is part of GNU CC.
***************
*** 2032,2038 ****
  
  (define_insn ""
    [(set (match_operand:SI 0 "general_operand" "=g<")
! 	(match_operand:QI 1 "address_operand" "p"))]
    ""
    "*
  {
--- 2032,2038 ----
  
  (define_insn ""
    [(set (match_operand:SI 0 "general_operand" "=g<")
! 	(match_operand:SI 1 "address_operand" "p"))]
    ""
    "*
  {


With greetings from the peanut gallery.
brgds, H-P


More information about the Gcc-patches mailing list