(patch) protoize fixes for windows32

Mumit Khan khan@nanotech.wisc.edu
Thu Jan 6 13:57:00 GMT 2000


Richard Henderson <rth@cygnus.com> writes:
> 
> Seems like you're missing some DIR_SEPARATOR_2 handling.
> Shouldn't this be
> 
> 	dir_last_slash = strrchr (dir_name, DIR_SEPARATOR);
> #ifdef DIR_SEPARATOR_2
> 	{
> 	  char *slash;
> 	  slash = strrchr (dir_last_slash ? dir_last_slash : dir_name,
> 			   DIR_SEPARATOR_2);
> 	  if (slash)
> 	    dir_last_slash = slash;
> 	}
> #endif
> 	if (dir_last_slash)
> 	  *dir_last_slash = '\0';
> 	else
> 	  abort ();  /* Should have been an absolutized filename.  */
> 
> There are two other similar fragments.

Precisely. Great catch! While I'm at it, I'll fix up two other dos 
related gotchas and post an updated patch for review in case 
there're objections to the new stuff.

Regards,
Mumit



More information about the Gcc-patches mailing list