[PATCH]: All unused functions and variables could be removed...

Martin v. Loewis martin@loewis.home.cs.tu-berlin.de
Wed Jan 5 15:01:00 GMT 2000


> Let's testing...

Thanks for your patch. I didn't review it in detail, but I see that you
made a lot of formatting changes of the style

-    ; /* cpp handles this one.  */
+    ; /* cpp handles this one.	*/

Please don't make these changes. It is the GNU coding convention to
have two spaces after a full stop, before the end of the
comment. Among other things, that makes Emacs auto-wrap work for
comments. Another set of changes is of the form

-   
+

or

-^L (actually, this should be a form feed)
+

Also, because of all these extra changes, it is very hard to see what
the patch actually does. If you remove these, you probably wouldn't
even need to compress the patch.

Regards,
Martin


More information about the Gcc-patches mailing list