Patch to merge (most of) elfos.h and svr4.h

Richard Henderson rth@cygnus.com
Wed Jan 5 13:56:00 GMT 2000


On Tue, Jan 04, 2000 at 05:03:30PM -0800, Nick Clifton wrote:
>   Whilst working on another problem I noticed that the files
>   gcc/config/elfos.h and gcc/config/svr4.h contain an awful lot of
>   duplicated definitions.  Since this seemed to me to be both
>   redundant and error prone I decided to try to eliminate this feature
>   and the patch below does this.

In general this is a good thing.  What targets did you test?

>     * The SELECT_SECTION macro in elfos.h included some extra code to
>       detect if flag_pic was set, and if so, to select the data
>       section.  This code was not present in the same version of the
>       macro in svr4.h...

Huh?  Look again.  Sure it did.

> + /* This is how to output a reference to a user-level label named NAME.
> +    `assemble_name' uses this.
> + 
> +    For System V Release 4 the convention is *not* to prepend a leading
> +    underscore onto user-level symbol names.  */

This is elfos.h, not svr4 -- please change the comment to 
"For most ELF systems the convention...".

>   /* The prefix to add to user-visible assembler symbols.
>   
>      For System V Release 4 the convention is *not* to prepend a leading
>      underscore onto user-level symbol names.  */
>   
> ! #undef  USER_LABEL_PREFIX
>   #define USER_LABEL_PREFIX ""
>   
>   /* Biggest alignment supported by the object file format of this
>      machine.  Use this macro to limit the alignment which can be
>      specified using the `__attribute__ ((aligned (N)))' construct.  If
>      not defined, the default value is `BIGGEST_ALIGNMENT'.  */
>   
> ! #define MAX_OFILE_ALIGNMENT (32768 * 8)

Why didn't these get moved to elfos.h?



r~


More information about the Gcc-patches mailing list