patch for compile/991229-3.c -O3 -fomit-frame-pointer -funroll-loops SH failure

Jeffrey A Law law@cygnus.com
Sat Feb 26 12:55:00 GMT 2000


  In message < 200002162012.UAA30288@phal.cygnus.co.uk >you write:
  > When doing the second loop optimization pass for 991229-3.c,
  > check_dbra_loop deletes the last insn that uses (reg:SI 62); unroll_loop
  > then proceeds to completely unroll the inner loop.   Thus, when scan_loop
  > processes the outer loop looking for movables, (reg:SI 62) is set in the 
  > last basic block, and the last use recorded in reg_n_info doesn't exist
  > anymore.
  > reg_in_basic_block_p currently aborts when it drops through to the end of
  > the function.  Here is a patch to fix this:
  > 
  > Wed Feb 16 20:06:58 2000  J"orn Rennecke <amylaar@cygnus.co.uk>
  > 
  > 	* loop.c (reg_in_basic_block_p): Don't abort when falling through
  > 	to the end of the function.
This is fine.  Though I would tweak the comment slightly by removing
"-- see gcc.c-torture ...".  We normally don't include that kind of stuff
in comments.  If someone tries to take the code out someday hopefully the
testsuite will trigger a failure or someone will have the good sense to
tell the contributor to check the archives for additional details about this
hunk of code.

Thanks,
jeff



More information about the Gcc-patches mailing list