Fix for expmod bootstrap failure

Alan Lehotsky lehotsky@tiac.net
Thu Dec 28 06:22:00 GMT 2000


Sorry, not off to a good start.

This patch was approved by Richard Henderson a month ago (11/22);  I 
had a long sequence of trouble getting
my gnu.org account activated and I stupidly cut corners when I should 
have known better.
Thank you for cleaning up after me, I will try not to let it happen again.




At 09:48 +0100 12/28/00, Andreas Jaeger wrote:

>Bootstrapping GCC CVS Current aborts with:
>
>/cvs/gcc/gcc/expmed.c: In function `store_bit_field':
>/cvs/gcc/gcc/expmed.c:402: too many arguments to function 
>`smallest_mode_for_size'
>
>Btw. I didn't see any notice (neither the patch nor an approval) for
>this patch on gcc-patches:
>2000-12-28    <lehotsky@tiac.net>
>
>	* expmed.c (store_bit_field): Correctly compute smallest mode that
>	is sufficient to contain all bits we are storing.
>
>I don't understand how it passed bootstrapping at all.
>
>I'm committing the appended patch under the obvious rule,
>Andreas
>
>2000-12-28  Andreas Jaeger  <aj@suse.de>
>
>	* expmed.c (store_bit_field): Fix last patch.
>
>Index: expmed.c
>===================================================================
>RCS file: /cvs/gcc/egcs/gcc/expmed.c,v
>retrieving revision 1.72
>diff -u -r1.72 expmed.c
>--- expmed.c	2000/12/28 05:55:03	1.72
>+++ expmed.c	2000/12/28 08:46:40
>@@ -399,7 +399,7 @@
>  	 VOIDmode, because that is what store_field uses to indicate that this
>  	 is a bit field, but passing VOIDmode to operand_subword_force will
>  	 result in an abort.  */
>-      fieldmode = smallest_mode_for_size (nwords * BITS_PER_WORD, 
>MODE_INT, 0);
>+      fieldmode = smallest_mode_for_size (nwords * BITS_PER_WORD, MODE_INT);
>
>        for (i = 0; i < nwords; i++)
>  	{
>
>
>
>--
>  Andreas Jaeger
>   SuSE Labs aj@suse.de
>    private aj@arthur.inka.de
>     http://www.suse.de/~aj

-- 
------------------------------------------------------------------------

		    Quality Software Management
		http://www.tiac.net/users/qsmgmt
			apl@alum.mit.edu
			(978)287-0435 Voice
			(978)808-6836 Cell
			(978)287-0436 Fax

	Software Process Improvement and Management Consulting
	     Language Design and Compiler Implementation


More information about the Gcc-patches mailing list