warning patch for mips.c

Jeffrey A Law law@cygnus.com
Mon Aug 21 07:58:00 GMT 2000


  In message < 200008211444.KAA27034@caip.rutgers.edu >you write:
  > @@ -6418,7 +6419,7 @@ save_restore_insns (store_p, large_reg, 
  >  		  && GET_MODE (base_reg_rtx) == SImode)
  >  		{
  >  		  insn = emit_move_insn (base_reg_rtx,
  > -					 GEN_INT (gp_offset & 0xffff0000U));
  > +					 GEN_INT (gp_offset & 0xffff0000));
  >  		  if (store_p)
  >  		    RTX_FRAME_RELATED_P (insn) = 1;
  >  		  insn
  > @@ -6636,7 +6637,7 @@ save_restore_insns (store_p, large_reg, 
  >  		  && GET_MODE (base_reg_rtx) == SImode)
  >  		{
  >  		  insn = emit_move_insn (base_reg_rtx,
  > -					 GEN_INT (fp_offset & 0xffff0000U));
  > +					 GEN_INT (fp_offset & 0xffff0000));
Err, is this really safe?  Why didn't you cast this to unsigned like you
did for constants in other places?

  >  		  if (store_p)
  > -					 GEN_INT (tsize & 0xffff0000U));
  > +					 GEN_INT (tsize & 0xffff0000));
Similarly.

Jeff



More information about the Gcc-patches mailing list