cpp token_buffer not being NULL terminated causes fixproto bugs

Kaveh R. Ghazi ghazi@caip.rutgers.edu
Sun Apr 30 07:04:00 GMT 2000

 > From: Zack Weinberg <zack@wolery.cumb.org>
 > I couldn't find any places where you missed an assumed NUL-
 > termination.  Would you care to give this patch a whirl on sunos4?  It
 > works for me on your errno.h example.  As a fringe bonus, we no longer
 > mess up glibc's getopt.h.
 > zw

Your patch works for me on SunOS4.  Thanks.

 > 	* fixproto: Don't redefine __STDC__ to 0.

FYI, the above __STDC__ change does seem to have an effect.  Mainly on
X11 files WRT which clause of #if __STDC__ conditionals gets diddled
with.  The header diffs look harmless though, but I thought you should
know.  I'm not sure whether we want to keep __STDC__=0 for platforms
which define STDC_0_IN_SYSTEM_HEADERS.  Something to think about.

Kaveh R. Ghazi			Engagement Manager / Project Services
ghazi@caip.rutgers.edu		Qwest Internet Solutions

More information about the Gcc-patches mailing list