Too restrictive sanity check

Jeffrey A Law law@cygnus.com
Wed Apr 19 15:22:00 GMT 2000


  In message < orwvluyeq4.fsf@zecarneiro.lsd.ic.unicamp.br >you write:
  > --=-=-=
  > 
  > The testcase in the attached patch fails to compile unless I disable
  > some sanity checks added by Jan Hubicka.  I've verified that the
  > generated code actually keeps the stack aligned, so I think the check
  > is too restrictive, or should be checking something else.  In this
  > case, stack_pointer_delta is 12, when we get to that point while
  > processing the outer function call.  Ok to install?
  > 
  > 
  > --=-=-=
  > Content-Type: text/x-patch
  > Content-Disposition: inline; filename=stack-align.patch
  > 
  > Index: gcc/ChangeLog
  > from  Alexandre Oliva  <oliva@lsd.ic.unicamp.br>
  > 
  > 	* calls.c (expand_call, emit_library_call_value_1): Comment out
  > 	the sanity check added by Jan Hubicka on Apr 12.
I was pretty sure the test was correct and that your patch was wrong
and just papering over a bug elsewhere -- I'd hit the same problem in
the PA64 port when I dropped it into the official GCC sources and
tried to bootstrap it.

I am grateful that you reduced the testcase to something manageable and
checked it into the testsuite.

jeff



More information about the Gcc-patches mailing list