PATCH: register coalescing in SSA

Richard Henderson rth@cygnus.com
Thu Apr 6 22:02:00 GMT 2000


On Thu, Apr 06, 2000 at 02:26:26PM -0700, Alex Samuel wrote:
> +       for_each_successor_phi (bb->index, &set_phi_alternative_reg, 
> + 			      new_live_at_end);

Please use a basic_block rather than an index where ever possible.

> + /* Routine to empty a dump file.  */
> + static void
> + clean_dump_file (suffix)
> +   const char *suffix;
> + {

This is a merge error.  I deleted this function earlier this week.

>   static partition compute_conservative_reg_partition 
> !   PARAMS (());

Recall that () is not the same as (void) in C.

> !   /* Don't eliminate dead code here.  The CFG we computed above must
> !      remain unchanged until we are finished emerging from SSA form --
> !      the phi node representation depends on it.  */
> !   life_analysis (get_insns (), max_reg_num (), NULL, 0);

Dead code elimination does not change the CFG.  I have cases where it
should, but I have never addressed that.  What was the real bug?



r~


More information about the Gcc-patches mailing list