protect __dso_handle
Mark Mitchell
mark@codesourcery.com
Tue Apr 4 23:53:00 GMT 2000
>>>>> "Ulrich" == Ulrich Drepper <drepper@redhat.com> writes:
Ulrich> This works mostly for C functions but can easily go wrong
Ulrich> for these pseudo ops. If you take a look at all the
Ulrich> different assemblers you'll see a multitude of pseudo ops
Ulrich> and I will almost bet there is a .hidden somewhere. With
Ulrich> C tests you have prototypes etc to make sure you get the
Ulrich> right function, with pseudo ops you can go wrong easily.
I thought that maybe this was what you were getting at.
>> But, I think the chances of another assembler accepting this
>> syntax, but having different semantics for it, are slim.
Ulrich> I don't think so.
OK, I'll trust your judgement.
Ulrich> The syntax used is so common since
Ulrich> there is not so much room for variation. Besides, if you
Ulrich> take a look at the configure.in file you'll see that the
Ulrich> tests are currently only run for gas.
I did look -- but I didn't see that. All I saw is that the test is
run if gcc_cv_as is set, and that appeared to be set if (for example)
`$AS' is set in the environment. But, if you say the tests are only
run for `gas' I'll believe you. I would appreciate it if you would
confirm this -- you don't need to convince me, but I would like to
that know you're sure.
Given that you've checked that, the patch is fine.
Thanks,
--
Mark Mitchell mark@codesourcery.com
CodeSourcery, LLC http://www.codesourcery.com
More information about the Gcc-patches
mailing list