cpplib: expression parser patch 4

Zack Weinberg zack@wolery.cumb.org
Sat Apr 1 18:37:00 GMT 2000

On Sun, Apr 02, 2000 at 10:27:15AM +0900, Neil Booth wrote:
> Zack Weinberg wrote:-
> > I like the patch.  However, before you commit it, please take some
> > time and add test cases for all the bugs fixed by this patch series to
> > the testsuite.  It's okay to add tests for bugs you haven't fixed yet.
> I'm not aware of any bugs I haven't fixed yet B-)
> Yes, I'd like to do this.  I have a file with 30-odd tests that I run
> cppmain through before I post, but I just manually scan the output of
> cppmain and the #error messages embedded in it to see if all is OK.
> I'm not completely sure how to add tests to the suite, but I get the
> general idea from the existing examples.  I'll post a patch soon and
> you can tell me what I did wrong.

gcc.dg is usually the right place for these tests.  Look at

> What I'm not clear on is if I can just compile cppmain and get the
> testsuite to run the preprocessor tests, without having to do a full
> gcc bootstrap each time I make a change?

This works pretty well:

make clean [if necessary]
runtest --tool gcc gcc.dg/dg.exp

Of course, you should do a full bootstrap and test run before you
actually commit anything.

> > Also I have a very few nits to pick:
> Is this patch OK?  If so I'll commit it after I've come up with a test
> suite.

Yes, this one is fine.


More information about the Gcc-patches mailing list