Patch: Add TOUPPER/TOLOWER to system.h and clean up ctype stuff

Kaveh R. Ghazi ghazi@caip.rutgers.edu
Thu Sep 30 23:58:00 GMT 1999


 > From: Richard Henderson <rth@cygnus.com>
 > 
 > On Wed, Sep 15, 1999 at 08:11:31PM -0400, Kaveh R. Ghazi wrote:
 > > Here is my patch rewrite which incorporates your suggestion.  I
 > > verified it does in fact eliminate the "subscript has type char"
 > > warnings.
 > 
 > Ok.
 > 
 > > +   WARNING!  The argument to CTYPE_CONV, and thus all ctype macros below,
 > > +   must not have side effects!
 > 
 > Actually, CTYPE_CONV is quite safe from side effects -- there is
 > one evaluation on each potential code path.  Not that we should
 > rely on side effects in ctype macros...
 > 
 > > +    printf ("%c", TOUPPER(*str));
 > 
 > This is putchar.
 > r~

	I fixed the comment and used putchar everywhere.  Installed.
Thanks for reviewing it.

		--Kaveh
--
Kaveh R. Ghazi			Engagement Manager / Project Services
ghazi@caip.rutgers.edu		Qwest Internet Solutions



More information about the Gcc-patches mailing list