PATCH to fix cpplib argument bug

Jeffrey A Law law@cygnus.com
Thu Sep 30 23:58:00 GMT 1999


  In message < 199909071838.LAA15321@zack.bitmover.com >you write:
  > Jeff Garzik wrote:
  > > This is a multi-part message in MIME format.
  > > --------------CA99743A66B49246EEE3C617
  > > Content-Type: text/plain; charset=us-ascii
  > > Content-Transfer-Encoding: 7bit
  > 
  > What did I say about MIME earlier?
  > 
  > [...]
  > > -  new = (cpp_buffer *) xcalloc (sizeof (cpp_buffer), 1);
  > > +  new = (cpp_buffer *) xcalloc (1, sizeof (cpp_buffer));
  > 
  > It shouldn't make any difference which order these are in.
While it doesn't make any difference, the second form is what I would
consider the standard form.  We want to ask for one cpp_buffer sized item,
not cpp_buffer single byte items :-)

jeff



More information about the Gcc-patches mailing list