Patch: varasm.c: assemble_variable tidy up
Nick Clifton
nickc@cygnus.com
Sat Sep 25 05:41:00 GMT 1999
Hi Richard,
: > + #elif defined ASM_OUTPUT_ALIGNED_LOCAL
:
: K&R didn't have elif. Rewrite either as nested ifs or as
: sequential ifndef ASM_EMIT_LOCAL.
*sigh* Still handicapped by K&R compliance... I will rewrite this.
: > + if (flag_shared_data)
: > + {
: [...]
: > + }
:
: Need something to make flag_shared_data and !flag_shared_data
: mutually exclusive -- a return or an else.
Err, but that is not how the original code worked. That code only
checked flag_shared_data if the appropriate ASM_OUTPUT_SHARED... was
defined, otherwise it jut dropped through into the normal
ASM_OUTPUT... code. Thats why in my rewrite I had the default case
for flag_shared_data do nothing but instead just let the program flow
continue on into the !flag_shared_data code.
Anyway I have I applied the patch with the #elif change, and if you
are convinced that the code should not emit a variable definition if
flag_shared_data is true, but there is no corresponding
ASM_OUTPUT_SHARED macro then I will that and check in a revision.
Cheers
Nick
More information about the Gcc-patches
mailing list