C++ Patch (Was: Virtual Mem Func Ptr Call Fails When BaseClass Has No Vtable)

Mark Mitchell markATcodesourcery.com
Wed Sep 15 07:39:00 GMT 1999


    >> Yes, sounds like the right fix to me.  Please do up the fix and
    >> submit it.

    Martin> Attached below. Because of re-indentation, it looks larger
    Martin> than it actually is.

This is fine. 

!       /* This used avoid checking for virtual functions if basetype
! 	 has no virtual functions, according to an earlier ANSI draft.
! 	 With the final ISO C++ rules, such an optimization is
! 	 incorrect.  */

Say `used to'; just `used' is ungrammatical.  And one more sentence
explaining that a virtual function in the derived class can be called
with a pointer to member of the base class wouldn't hurt.

Thanks!

--
Mark Mitchell                   mark@codesourcery.com
CodeSourcery, LLC               http://www.codesourcery.com


More information about the Gcc-patches mailing list