va_list: sh

[Joern Rennecke]

> Mostly straightforward.  There are a few points.
> 
>   * The cute postinc asm stuff appears to be wrong for big-endian.

Why that?

>   * The sh port does not define FUNCTION_ARG_PASS_BY_REFERENCE,
>     so the bits in __va_arg_sh1 about structures via indirection
>     must be wrong.  Either that or the compiler is.

There is nothing about structures via indirection there.

>   * Please double-check the condition
> 
> 	((! TARGET_SH3E && ! TARGET_SH4) || TARGET_HITACHI)

You can simplify this to:

> 	(! TARGET_SH3E || TARGET_HITACHI)
> 
> I tested sh-elf with "" and "-m4".

Did you test for apparent correctness or code quality?