cpplib: unnecessary cast removal [patch]

Zack Weinberg zack@bitmover.com
Fri Oct 15 11:17:00 GMT 1999


I'm committing this as an obvious bugfix.  It removes an unnecessary
cast and makes an internal function static.

zw

1999-10-15 11:16 -0700  Zack Weinberg  <zack@bitmover.com>

	* cppexp.c (cpp_parse_escape): Make static.  Change second arg
	to U_CHAR **.
	(parse_charconst): Delete unnecessary cast when calling
	cpp_parse_escape.
	(cpplib.h): Kill prototype of cpp_parse_escape.

===================================================================
Index: cppexp.c
--- cppexp.c	1999/09/09 04:00:36	1.27
+++ cppexp.c	1999/10/15 18:15:36
@@ -84,6 +84,7 @@ static struct operation parse_number PAR
 static struct operation parse_charconst PARAMS ((cpp_reader *, U_CHAR *, U_CHAR *));
 static struct operation cpp_lex PARAMS ((cpp_reader *, int));
 extern HOST_WIDEST_INT cpp_parse_expr PARAMS ((cpp_reader *));
+static HOST_WIDEST_INT cpp_parse_escape PARAMS ((cpp_reader *, U_CHAR **, HOST_WIDEST_INT));
 
 #define ERROR 299
 #define OROR 300
@@ -291,7 +292,7 @@ parse_charconst (pfile, start, end)
 	     an unshifted multibyte char, so cpp_parse_escape doesn't
 	     need to know about multibyte chars.  */
 
-	  c = cpp_parse_escape (pfile, (char **) &ptr, mask);
+	  c = cpp_parse_escape (pfile, &ptr, mask);
 	  if (width < HOST_BITS_PER_INT
 	      && (unsigned int) c >= (unsigned int)(1 << width))
 	    cpp_pedwarn (pfile, "escape sequence out of range for character");
@@ -522,10 +523,10 @@ cpp_lex (pfile, skip_evaluation)
    If \ is followed by 000, we return 0 and leave the string pointer
    after the zeros.  A value of 0 does not mean end of string.  */
 
-HOST_WIDEST_INT
+static HOST_WIDEST_INT
 cpp_parse_escape (pfile, string_ptr, result_mask)
      cpp_reader *pfile;
-     char **string_ptr;
+     U_CHAR **string_ptr;
      HOST_WIDEST_INT result_mask;
 {
   register int c = *(*string_ptr)++;
===================================================================
Index: cpplib.h
--- cpplib.h	1999/09/23 20:40:51	1.42
+++ cpplib.h	1999/10/15 18:15:36
@@ -721,7 +721,6 @@ extern void cpp_perror_with_name PROTO (
 extern void v_cpp_message PROTO ((cpp_reader *, int, const char *, va_list));
 
 extern void cpp_grow_buffer PARAMS ((cpp_reader *, long));
-extern HOST_WIDEST_INT cpp_parse_escape PARAMS ((cpp_reader *, char **, HOST_WIDEST_INT));
 extern cpp_buffer *cpp_push_buffer PARAMS ((cpp_reader *,
 					    unsigned char *, long));
 extern cpp_buffer *cpp_pop_buffer PARAMS ((cpp_reader *));


More information about the Gcc-patches mailing list