ppc va-arg-10 fix

Mark Mitchell mark@codesourcery.com
Sun Oct 3 09:10:00 GMT 1999


>>>>> "Franz" == Franz Sirl <Franz.Sirl-kernel@lauterbach.com> writes:

    Franz> Am Die, 28 Sep 1999 schrieb Franz Sirl:
    >> BTW, I could reproduce the va_arg problem reported by Raja R
    >> Harinath <harinath@cs.umn.edu> on gcc-bugs on Linux/PPC as
    >> well.

    Franz> Hi Richard, the appended small patch fixes it on Linux/PPC.

This patch is correct.  It's something of a design defect, in my
opinion, that the tree-building routines do not automatically set
TREE_SIDE_EFFECTS for VA_ARG_EXPR, RTL_EXPR, INIT_EXPR, MODIFY_EXPR,
and a few other such nodes.  I've certainly more than once tracked
down the same bug you found, whereby an expression is not expanded by
expand_expr because it is not marked as having side-effects.

Does anyone disagree?  Otherwise, I'll put together a patch for
`make_node' that fixes this.

--
Mark Mitchell                   mark@codesourcery.com
CodeSourcery, LLC               http://www.codesourcery.com


More information about the Gcc-patches mailing list