cppinit.c : space in `CAT' argument list

Jeffrey A Law law@cygnus.com
Tue Nov 30 00:39:00 GMT 1999


  In message < 199911291430.PAA02771@mail.macqel.be >you write:
  > >   > Fri Nov 26 10:54:50 1999  Philippe De Muyter  <phdm@macqel.be>
  > >   > 
  > >   > 	* cppinit.c (CAT): The argument list of this macro may not cont
  > ain
  > >   > 	spaces !
  > > More detail please.  Precisely why does the space cause problems?
  > 
  > Sorry, I thought it was self-explanatory : the macro `CAT' concatenates
  > its arguments to build an identifier.  For old preprocessor, one
  > uses the `/**/' trick instead of `##'.  This does of course not remove the
  > spaces outside `/**/'.
Don't assume patches are self-explanatory.  The more information you provide,
the easier it will be for people to review your patch, particularly for those
of us who often end up looking at more than dozen patches every day.  And
(of course) the easier it is for us to review your patch, the more likely you
it will get properly reviewed in a timely fasion.

I'll note that other (non-ansi) pre-processors I've used didn't barf of this
code (yes, I tried them in an attempt to figure out why you made the change).


  > Fri Nov 26 10:54:50 1999  Philippe De Muyter  <phdm@macqel.be>
  > 
  > 	* cppinit.c (CAT): The argument list of this macro may not contain
  > 	spaces !
Thanks.  Installed.




More information about the Gcc-patches mailing list