fixincl.c uses non-portable #error and string concatenation

Alexandre Oliva oliva@dcc.unicamp.br
Mon May 31 20:56:00 GMT 1999


On May 18, 1999, Jeffrey A Law <law@upchuck.cygnus.com> wrote:

>   In message < orso8vwb13.fsf@lua.lbi.dcc.unicamp.br >you write:

>> We could remove the explicit adjacent strings from inclhack.def, but
>> fixincl.tpl would have to be modified somehow in order to generate a
>> single string even for multiple files, instead of multiple adjacent
>> strings.  Bruce, how can we achieve this with AutoGen?  Couldn't we
>> use AutoGen to merge adjacent strings in inclhack.def too?

> Ew.  Yup, we need to fix these.

Bruce has sent me a patch for AutoGen and fixincl that would allegedly
take care of concatenating strings.  Unfortunately, the patch was
messed up because the message was returned and resent, and the MIME
attachment was rendered useless.  Bruce, could you please send it
again, or post it here?

>> * fixinc/fixincl.c: Remove #error, it is not portable.

> I went ahead and installed this.  No sense in making it wait if there's
> issues with your patch to deal with all the issues you raised in this
> message.

Thanks.  Removing the fixes related with the autogen shortcoming, the
remaining portability fixes are attached.  Ok to install?

-- 
Alexandre Oliva http://www.dcc.unicamp.br/~oliva IC-Unicamp, Bra[sz]il
{oliva,Alexandre.Oliva}@dcc.unicamp.br  aoliva@{acm.org,computer.org}
oliva@{gnu.org,kaffe.org,{egcs,sourceware}.cygnus.com,samba.org}
*** E-mail about software projects will be forwarded to mailing lists


More information about the Gcc-patches mailing list