PATCH for expand_end_bindings

Franz Sirl Franz.Sirl-kernel@lauterbach.com
Sat May 22 10:56:00 GMT 1999


Am Sat, 22 May 1999 schrieb mark@codesourcery.com:
>This patch modifies expand_end_bindings to ignore any elements of the
>VARS list it is passed that are not VAR_DECLs.  It almost did this
>already, but would ocasionally look at DECL_RTL for things that were
>not DECLs.  (It's convenient for the C++ front-end to be able to put
>non-VAR_DECLs on this list.)
>
>I'd like to put this patch on the branch as well since it avoids
>accessing nodes incorrectly, which we sometimes did, even for legal
>code.
>
>(BTW, this is more stuff revealed by --enable_checking.)
>
>--
>Mark Mitchell                   mark@codesourcery.com
>CodeSourcery, LLC               http://www.codesourcery.com
>
>Fri May 21 15:39:51 1999  Mark Mitchell  <mark@codesourcery.com>
>
>	* stmt.c (expand_end_bindings): Ignore any elements of VARS that
>	are not VAR_DECLs.

Wow, great work, thanks. With this patch applied to my gcc-2.95pre tree the g++
testsuite passes all tests with and without --enable-checking now. Closer
inspection shows that some XFAILs still trigger the error message, but these
are hopefully kind of harmless :-).

May I suggest to handle --enable-checking now the same way as WARN_CFLAGS?
Enabled for development, disabled for releases?

Thanks again,

Franz.


More information about the Gcc-patches mailing list