Do not replace GIVs containing volatile memory references

Nick Clifton nickc@cygnus.com
Wed Mar 31 18:59:00 GMT 1999


Hi Craig,

: > Thu Mar 18 15:58:26 1999  Nick Clifton  <nickc@cygnus.com>
: >
: >	 * loop.c (strength_reduce): Do not perform pseudo replacements
: >	 if the loop contains volatile memory references.
: 
: Just a note: you are presumably aware your change will have no effect
: whatsoever on the code as it *currently* stands, right?  The "0 &&"
: at the beginning of the test assures that.

Yup!  I am aware of this!

: Not that this is therefore not a good change -- the "Temporary" and
: "0 &&" strongly suggest the test might be re-enabled someday soon,
: and if it needs to be a better test, so be it...
: 
: ...just wanted to make sure you weren't expecting to see changes in
: generated code as a result of this patch.


Yeah - I have a branch which has this test enabled, and this is where
I originally discovered the problem...

Thanks for noting this though.

Cheers
	Nick




More information about the Gcc-patches mailing list