A patch to constify gcc.c (Really, summarizing remaining warnings)

Richard Henderson rth@cygnus.com
Wed Mar 31 18:59:00 GMT 1999


On Thu, Mar 11, 1999 at 11:08:45AM -0500, Kaveh R. Ghazi wrote:
> I guess you could create a new function out of the code in between the
> two calls to set_float_handler() and pass that function pointer to
> do_float_handler().  Then if do_float_handler() returned 0, you'd
> return 0?

Yes.

> How would you pass all the necessary data in a void *?
> Would you create a customized struct with all the info passed in and
> out and then call do_float_handler() with the struct as the second
> argument?

Yes.

> 	Also, let's assume what I describe above is accurate and we did
> it.  Out of curiosity, if I happened to bootstrap with -O3, and then
> do_float_handler() is inlined, would the errors come back?

Given that I'd expect do_float_handler to live next to set_float_handler
in toplev.c, I would not expect it to be inlined.

But answering the question you actually asked, yes, if it were inlined
the errors would come back.


r~



More information about the Gcc-patches mailing list