A warning patch, ptr assignment cleanup + error w/define after col 0

Zack Weinberg zack@rabi.columbia.edu
Wed Mar 31 18:59:00 GMT 1999


On Fri, 19 Mar 1999 15:28:27 -0500 (EST), "Kaveh R. Ghazi" wrote:
> > Why not change sym to an unsigned char * ?
>	As far as I could tell, it would have required a similar number
>of casts in the other direction.  (I could be wrong though.)

I really don't like the way we use char, unsigned char, U_CHAR, and
sometimes int with little rhyme or reason all over cpplib.  It ought to be
disentangled.  There are potential bugs in there wrt 8-bit cleanliness (e.g.
indexing into one of the is_* tables with a signed char with the high bit
on)

Of course, the standard string functions' insisting on taking a char *
doesn't help.

zw



More information about the Gcc-patches mailing list