egcs/libiberty includes missing fix
Kaveh R. Ghazi
Wed Jun 30 23:15:00 GMT 1999
> From: "Philippe De Muyter" <email@example.com>
> > I will install your (incomplete) patch in the gcc-2.95 tree only.
> > You need to make the changes I requested before I will accept this
> > patch for the main sources.
> Thanks. However, my patch is a complete patch for the problem that
> `size_t' and `NULL' are not defined if the appropriate header files
> are not #include'd, so I think it should go also in the main tree.
> > Specifically you need to write the includes in suitable autoconf
> > conditionals
> I do not think that we must test for existence of stdio.h or
> sys/types.h, and there is no use of HAVE_STDIO_H or HAVE_SYS_TYPES_H
> in the whole egcs tree.
Correct. In gcc/system.h, stdio.h and sys/types.h, as well as
ctype.h and errno.h are used unconditionally. They are not tested for
However the "char * malloc ();" is not okay. At the very least it
should be "PTR malloc();" and better yet would be to autoconfiscate it
as Jeff requested.
> > and use NEED_DECLARATION_MALLOC to protect any declarations of malloc.
> Kaveh R Ghazi wrote on the list that he would do this job, but there
> were questions about the master version of libiberty.
Actually, I was waiting until after the 2.95 release since
Jeff told me that he won't be reviewing any configury
(i.e. non-critical bugfix) patches until then. (Jeff if this is
higher priority, let me know and I'll do it sooner.)
Kaveh R. Ghazi Engagement Manager / Project Services
firstname.lastname@example.org Qwest Internet Solutions
More information about the Gcc-patches