(patch) pragma pack lossage

Mumit Khan khan@xraylith.wisc.EDU
Wed Jun 30 23:15:00 GMT 1999


Robert Lipe <robertlipe@usa.net> writes:
> > All targets that support SYSV pragmas now also support #pragma pack(<n>). 
> > This code is handled by c-pragma.c:handle_pragma_token() that sets the
> 
> As the maintainer of one SYSV target that has zillions of #pragma
> pack(<n>) directives in the headers that has been sunk by other changes
> in this code I can confirm that this patch, once applied, does allow a
> 'make clean; make bootstrap' of gcc/ on the 2.95 tree.
> 
> This is meant not as an endorsement of the patch (like Mumit needs my
> endorsements. :-) but as affirmation that it doesn't sink the 'System V + 
> pragma pack + (pragma push==don't care)' case.

Thanks for the heads-up. It's always good to test a few other platforms
to make sure nothing broke inadvertently.

btw, thanks for pointing out the typo in my patch:
  
  HANDLE_PRAGMA_PAC_PUSH_POP -> HANDLE_PRAGMA_PACK_PUSH_POP
                  ^^ K missing here

I'll resubmit with the typo fixed when I see a review of it.

Regards,
Mumit



More information about the Gcc-patches mailing list